Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ctrl+b shortcut should not trigger browser native actions #1342

Merged
merged 3 commits into from May 22, 2024

Conversation

AyushAgrawal-A2
Copy link
Contributor

@AyushAgrawal-A2 AyushAgrawal-A2 commented May 11, 2024

closes #1337

Bug:

  • Due to awaiting an async function call for shortcut action, browser native action gets triggered before preventDefault and stopPropagation is called.

Changes:

  • Shortcut action is now being executed asynchronously in background without await.

Copy link

cla-bot bot commented May 11, 2024

We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact.

Copy link

vercel bot commented May 11, 2024

@AyushAgrawal-A2 is attempting to deploy a commit to the Quadratic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

cla-bot bot commented May 14, 2024

We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact.

@cla-bot cla-bot bot added the cla-signed label May 14, 2024
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview May 22, 2024 3:02am

@davidkircos davidkircos merged commit a3dae12 into quadratichq:main May 22, 2024
8 of 11 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/1337 branch May 22, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nit: cmd + b not unbolding and on brave leading to bookmarks getting opened
2 participants