Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applying a wallpaper image does not get rid of the old one #4772

Closed
2 tasks done
PhoenixClank opened this issue Apr 17, 2024 · 5 comments · Fixed by #4785
Closed
2 tasks done

applying a wallpaper image does not get rid of the old one #4772

PhoenixClank opened this issue Apr 17, 2024 · 5 comments · Fixed by #4785
Labels
status: unconfirmed

Comments

@PhoenixClank
Copy link

Issue description

It seems like the new wallpaper image is added to the old one, which causes it to get iteratively brighter. For example, this is how my screen is supposed to look:
a regular-looking photo
And this is how it looks like after reloading config five times:
a very over-exposed-looking photo

Version

0.25.1.dev0+g005da458.d20240413

Backend

Wayland (experimental)

Config

No response

Logs

No response

Required

  • I have searched past issues to see if this bug has already been reported, and it hasn't been.
  • I understand that people give their precious time for free, and thus I've done my very best to make this problem as easy as possible to investigate.
@elParaguayo
Copy link
Member

This could have been caused by #4621

Pinging @jwijenbergh as this is Wayland...

@wingej0
Copy link
Contributor

wingej0 commented Apr 18, 2024

I can confirm this on my machine as well. I posted a screencast of it on the Discord server.

@jwijenbergh
Copy link
Contributor

Which gpu? Also can you share the wallpaper?

@PhoenixClank
Copy link
Author

It's the integrated graphics of an AMD Ryzen 5 5500U. The wallpaper is at https://s20.directupload.net/images/240422/87h4htpr.png. It gets downscaled to 1920x1080 with the "fill" wallpaper mode of qtile.

jwijenbergh added a commit to jwijenbergh/qtile that referenced this issue Apr 28, 2024
@jwijenbergh
Wayland WLRQ: Clear the old background with cairo
1f6c141 
There is now a bug that the old background is never cleared (from qtile#4621). Let's
use cairo for that (and fill the empty space with black). But, let's
still do the scaling using the GPU.

Hopefully fixes: qtile#4772 and also now if you apply a wallpaper but it
doesn't fully contain the whole screen (mode=""), the empty space is
now black instead of the old wallpaper. As far as I can tell this
also was a bug before qtile#4621
@jwijenbergh jwijenbergh mentioned this issue Apr 28, 2024
Merged
@jwijenbergh
Copy link
Contributor

Can anyone try #4785 ?

elParaguayo pushed a commit that referenced this issue May 3, 2024
@jwijenbergh @elParaguayo
Wayland WLRQ: Clear the old background with cairo
53f3711 
There is now a bug that the old background is never cleared (from #4621). Let's
use cairo for that (and fill the empty space with black). But, let's
still do the scaling using the GPU.

Hopefully fixes: #4772 and also now if you apply a wallpaper but it
doesn't fully contain the whole screen (mode=""), the empty space is
now black instead of the old wallpaper. As far as I can tell this
also was a bug before #4621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: unconfirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wayland WLRQ: Clear the old background with cairo jwijenbergh/qtile
4 participants
@elParaguayo @wingej0 @PhoenixClank @jwijenbergh