Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save path should utilize ds.Commit.ID, ds.Name, and ds.Peername instead of a ref #1913

Open
b5 opened this issue Sep 16, 2021 · 0 comments
Open
Labels
refactor A code change that neither fixes a bug nor adds a feature save path issues around constructing new dataset commits

Comments

@b5
Copy link
Member

b5 commented Sep 16, 2021

we've run into this most recently in #1911, and have known about this issue for a while. We could clean up TODOs like this one:

qri/base/save.go

Lines 133 to 135 in d451f6f

// TODO(dustmop): Remove the dependence on the ds having an assigned Name. It is only
// needed for updating the refstore. Either pass in the reference needed to update the refstore,
// or move the refstore update out of this function.

Now that we have the collection subsystem to manage references independent of the save path

@b5 b5 added refactor A code change that neither fixes a bug nor adds a feature save path issues around constructing new dataset commits labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature save path issues around constructing new dataset commits
Projects
None yet
Development

No branches or pull requests

1 participant