Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to render scrolling position #85

Open
BugCreators opened this issue Apr 10, 2024 · 2 comments
Open

unable to render scrolling position #85

BugCreators opened this issue Apr 10, 2024 · 2 comments

Comments

@BugCreators
Copy link
Contributor

Same question in bubkoo/html-to-image#81

And, I noticed there's a PR#209 attempting to solve this problem, I implemented it on my fork.

The effect is as follows:

1

Can I make a PR? I may need help adding test cases as I am unable to run the test

Steps To Reproduce

Playground for https://codesandbox.io

Your Environment

  • modern-screenshot: 4.4.33
  • Browser: Chrome/123.0.0.0
@qq15725
Copy link
Owner

qq15725 commented Apr 10, 2024

Good, welcome to submit PR, but I prefer to move the option to features

The default value can be false(If there are other issues with the first version of the implementation), which does not affect other feature

@qq15725
Copy link
Owner

qq15725 commented Apr 10, 2024

#52 #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants