Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests take too long to complete #57

Open
phoebe-p opened this issue Mar 20, 2023 · 0 comments
Open

Tests take too long to complete #57

phoebe-p opened this issue Mar 20, 2023 · 0 comments

Comments

@phoebe-p
Copy link
Member

Not really a bug, but some tests take a long time to complete, particularly those in test_compare_methods which compare absorption profiles calculated with the angular redistribution matrix method and with just ray-tracing or TMM. It's necessary to use a lot of angle bins/rays to allow convergence and good agreement with the "pure" RT/TMM methods, but also very slow. Should try to find a middle ground which does not take as long to complete on GitHub Actions, or perhaps run these tests separately (scheduled).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant