Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process_structure doesn't work as expected if non-valid optical method is specified #35

Open
phoebe-p opened this issue Aug 10, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@phoebe-p
Copy link
Member

Describe the bug
Currently, if anything other than the valid optical methods ("RT_Fresnel", "RT_TMM", "RCWA", "TMM", "Mirror", "Lambertian") for the angular redistribution matrix method is specified in an Interface, the matrices for that interface are simply not calculated during process_structure, but no error or warning is given. Obviously, this leads to failure later on when trying to calculate_RAT because the expected files are not found.

To Reproduce
Steps to reproduce the behavior:

bad_surface = Interface('Non_existent_method', layers=[],
                                name ='test')
bad_structure = Structure([bad_surface, bulk, bad_surface],
                    incidence=Air, transmission=Air)
process_structure(bad_structure, options)
RAT = calculate_RAT(bad_structure, options)

Expected behavior
process_structure should give an error rather than failing silently.

@phoebe-p phoebe-p added the bug Something isn't working label Aug 10, 2021
@phoebe-p phoebe-p self-assigned this Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant