Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

janino-fragment should use DynamicImport not Require-Bundle #22

Open
diamondq opened this issue Sep 10, 2018 · 0 comments
Open

janino-fragment should use DynamicImport not Require-Bundle #22

diamondq opened this issue Sep 10, 2018 · 0 comments

Comments

@diamondq
Copy link

The janino-fragment leverages Require-Bundle to force the Janino library to retrieve classes from the Logback libraries. However, Require-Bundle is rigid, in that it assumes that the only location for Logback classes is in the logback library.

Unfortunately, the PAX Logging team (which is one of the most used OSGi logging libraries) wrapped/embedded the logback libraries into their library. Therefore, the original logback JARs are not usually present in an OSGi environment.

By changing the Require-Bundle to a
DynamicImport-Package: ch.qos.logback.*
the code becomes more flexible as it won't care which bundle provides the packages.

chrisrueger added a commit to chrisrueger/logback-contrib that referenced this issue Feb 2, 2020
* replaced Require-Bundle with DynamicImport-Package
* to allow janino-fragment see classes in ch.qos.logback.classic  (instead of just ch.qos.logback.core): e.g. ch.qos.logback.classic.Level 
* also added org.slf4j which is also required to be visible and is currently missing
* needed in OSGI environments
* see qos-ch#28 for details
* this also fixes the change request in qos-ch#22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant