Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong padding applied when currency is explicitly not defined #743

Open
vscav opened this issue Feb 2, 2024 · 0 comments · May be fixed by #766
Open

Wrong padding applied when currency is explicitly not defined #743

vscav opened this issue Feb 2, 2024 · 0 comments · May be fixed by #766
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@vscav
Copy link
Member

vscav commented Feb 2, 2024

Today, it is possible to explicitly pass undefined or null to the @currency argument of the AmountInput component.

It is convenient when we want to benefit from the behavior of the amount input without showing any currency information (use case example: the currency information is displayed in another element, next to the input - here we wouldn't want to have the currency displayed twice for the same information).

However, when doing so, the padding stays the same, meaning we have a larger padding-right (i.e. 41px) in the input, that is usually set to be able to display the currency.

Capture d’écran 2024-02-02 à 14 52 41

If the currency is explicitly set to undefined, null, or to an empty string, we should reset the padding (from 41px to 12px).

@vscav vscav added bug Something isn't working good first issue Good for newcomers labels Feb 2, 2024
@vscav vscav self-assigned this Feb 21, 2024
@vscav vscav removed their assignment Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
1 participant