Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convertor chaining #78

Open
adekusar-drl opened this issue Apr 13, 2021 · 0 comments
Open

Add convertor chaining #78

adekusar-drl opened this issue Apr 13, 2021 · 0 comments

Comments

@adekusar-drl
Copy link
Contributor

What is the expected enhancement?

Right now all optimizers manually deal with converters. Sometime this logic is the same across several optimizers. This issue suggests to stream line the way converters are applied in optimizers.

Problem conversion should be placed in the base class. Then, the base class should have a generic solve() method, that makes everything ready for sub-classes and call an abstract _solve() method of the base class, which, in turns, is implemented in a concrete optimizer. This concrete _solve() implementation is tailored to the needs of the optimizer and does not deal with converters unless it is truly required by the optimizer.

So, ideally optimizers should not know of any conversions took place before theirs _solve() method is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant