Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render as a surface added to point cloud 2D renderers #9050

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

selmaVH1
Copy link
Collaborator

fixes #9024

Comment on lines 425 to 427
You can control the horizontal length of computed triangles:

* |checkbox| :guilabel:`Skip triangles longer than` a threshold value:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it is a single option, I don't think a list is necessary here.

Comment on lines 431 to 433
Through the :guilabel:`Shading Renderer` in the :guilabel:`Layer Styling` panel
you can access the :ref:`Global Map Shading <global_map_shading>` which is also
supported by this option.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't get why map shading is mentioned here while we don't do it for other configs this option is compatible with. IMHO, putting the screenshot with map shading rendering should be enough.

Comment on lines 435 to 454
.. _figure_clasification_render_surface_example:

.. figure:: img/clasification_render_surface_example.png
:align: center

Example of Render as a surface (Triangulate) option in Classification renderer

.. _figure_RGB_render_surface_example:

.. figure:: img/RGB_render_surface_example.png
:align: center

Example of Render as a surface (Triangulate) option in RGB renderer

.. _figure_shading_render_surface_example:

.. figure:: img/shading_render_surface_example.png
:align: center

Global map shading when `Render as a Surface` is enabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fan of this block of examples.
Given that they showcase combination with different renderers, I would suggest to:

  1. Move each pair of images to their renderer section (rgb, classification) - whether these images should replace the corresponding GUI screenshot or live along is an open question
  2. Keep only the shading map screenshot in this place.
  3. And as much as possible, let's put descriptive text out of the image so that people can have it translated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm considering adding a reference to the 'Render as a Surface' section in the image description, while keeping the GUI screenshots unchanged. However, I'm concerned that this might confuse users, especially those who are working with point clouds for the first time. If we were to update the screenshots, would we then need to mention the 'Point Symbol' and 'Layer Rendering' within the renderer sections as well?
The block of examples is not the best solution, but in my opinion, it contributes to a better understanding of the feature in general. Is there a technical reason why you're not a fan of the block of examples? Or is this preference based on your experience with documentation writing? I'd appreciate any insights you could share. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Render as a surface" option to 2D point cloud renderers (Request in QGIS)
2 participants