Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torrent hash in search plugins #45

Open
ngosang opened this issue Sep 16, 2018 · 3 comments
Open

Add torrent hash in search plugins #45

ngosang opened this issue Sep 16, 2018 · 3 comments

Comments

@ngosang
Copy link
Member

ngosang commented Sep 16, 2018

I'm able to get the torrent hash from most search engines so we can implement these features:

I'm also able to do it in a manner that old plugins (unofficial) still works in new qbittorrent. And the new plugins (with hash support) works in old qbittorrent versions.

I can do the change in search plugins and the change need in novaprinter.py. There is no need to change the c++ code, but would be nice if you add a new column with the hash.
Now, nova2.py returns (desc_link is optional):

link|name|size|seeds|leech|engine_url|**desc_link**

Whit the changes will be (all compulsory, but last 2 can be empty):

link|name|size|seeds|leech|engine_url|desc_link|hash

What do you think? @Chocobo1 @sledgehammer999 @Piccirello @zeule

@nindogo
Copy link
Contributor

nindogo commented Sep 16, 2018

In some cases to get the hash you may have to go into the desc_link. If there were say 300 results that may take time, even threaded, and appear slow no?

Maybe I am wrong and users may be OK with a little bit longer delay in exchange of not having 2 identical torrent results?

@ngosang
Copy link
Member Author

ngosang commented Sep 16, 2018

In some cases to get the hash you may have to go into the desc_link. If there were say 300 results that may take time, even threaded, and appear slow no?

I'm not going to do that. In most search engines (all but 1337x) I can get the hash from the main page. If it's not in the main page I will leet the hash as "Unknown".

@rmlrml
Copy link

rmlrml commented Mar 14, 2019

Just a user here. I came searching the github issues to see if hash column in the search tab was already a requested feature. I personally was just hoping for a hash column, didn't think of or care about grouping duplicate results of the same torrent into one row.

I often will try to sort by size column or name column just to gather multiple results of the same torrent together, then download all of them just in case one has trackers that the others don't. But sizes aren't always reported exactly the same by each engine, and names are often different. If there were a hash column I could just sort by that, select all of the results having the same hash and click download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants