Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to the UI the public IP address being used #18573

Open
redtripleAAA opened this issue Feb 14, 2023 · 14 comments
Open

Add to the UI the public IP address being used #18573

redtripleAAA opened this issue Feb 14, 2023 · 14 comments
Labels
Feature request GUI GUI-related issues/changes

Comments

@redtripleAAA
Copy link

Suggestion

Feature Request: to add to the UI the public IP address being used

Use case

This is useful for quickly identify the network qbittorrent is using.

Extra info/examples/attachments

Deluge app does have. this feature already

@thalieht thalieht changed the title Feature Request: to add to the UI the public IP address being used Add to the UI the public IP address being used Feb 14, 2023
@Granzort47
Copy link

Second!

@glassez
Copy link
Member

glassez commented Feb 15, 2023

You can see it in the Log. Is there such an urgent need to keep it constantly in front of your eyes?
In addition, qBittorrent can use several network interfaces connected to a public network, IIRC.

@luzpaz
Copy link
Contributor

luzpaz commented Jul 1, 2023

Related to #12921

@OdinVex
Copy link

OdinVex commented Aug 20, 2023

You can see it in the Log. Is there such an urgent need to keep it constantly in front of your eyes? In addition, qBittorrent can use several network interfaces connected to a public network, IIRC.

Absolutely a desperate urgent need to verify things are working through VPN, yes. This would really be appreciated, since Deluge has had it for years.

@luzpaz
Copy link
Contributor

luzpaz commented Aug 20, 2023

Can you make a mockup of your proposal ?

@OdinVex
Copy link

OdinVex commented Aug 20, 2023

Can you make a mockup of your proposal ?

I won't bother, Deluge already did (bottom): https://dl.flathub.org/repo/screenshots/org.deluge_torrent.deluge-stable/752x423/org.deluge_torrent.deluge-9315e0e968847894130970e02f2fdd8a.png

Many web-interfaces that show external IPs allow you to specify the URL to obtain the information from and the fetch/update interval as well.

@luzpaz luzpaz added the GUI GUI-related issues/changes label Aug 21, 2023
@OdinVex
Copy link

OdinVex commented Dec 7, 2023

Decided to finally get off my behind and look at the job. Easier than I thought. Submitted a Pull Request.

@ZaxLofful
Copy link

Similar request:

#19253

@OdinVex
Copy link

OdinVex commented Dec 10, 2023

Similar request:

#19253

I posted a working solution that could be backported to earlier stable versions, worked GUI and WebUI, they didn't want it. Closed the PR. Deluge is still apparently the only one to get it right about displaying externally-detected IP addresses. I meet less toxic devs working on the Linux Kernel. *shrug*

@ZaxLofful
Copy link

ZaxLofful commented Dec 11, 2023

They didn't say they didn't want it, they said they wanted to adjust it a bit; then you got mad and closed it yourself.

No one actually rejected your PR...

EDIT: Thanks for opening up a new PR: #20118

@OdinVex
Copy link

OdinVex commented Dec 11, 2023

They didn't say they didn't want it, they said they wanted to adjust it a bit; then you got mad and closed it yourself.

No one actually rejected your PR...

I read several posts yesterday otherwise that don't appear there today. I wasn't the only one to read them either. I'm not re-hashing things, so why are you bringing that back up? They can easily read the original PR. I'd still rather dev with Linus Torvald's old behavior, for whatever that might convey in response.

@ZaxLofful
Copy link

#20118

They didn't say they didn't want it, they said they wanted to adjust it a bit; then you got mad and closed it yourself.
No one actually rejected your PR...

I read several posts yesterday otherwise that don't appear there today. I wasn't the only one to read them either. I'm not re-hashing things, so why are you bringing that back up? They can easily read the original PR.

Because you ARE re-hashing things, "I posted a working solution that could be backported to earlier stable versions, worked GUI and WebUI, they didn't want it. Closed the PR. Deluge is still apparently the only one to get it right about displaying externally-detected IP addresses. I meet less toxic devs working on the Linux Kernel. shrug"

^If that is not re-hashing something, it explains; why you don't understand normal logic^

You would have had to delete them yourself, GitHub doesn't allow others to delete your comments for you. It just sounds like you are trying to shift the blame for being rude.

So far the only one acting like a child on a public PR request, is you....

You were being rude, because people asked you to change your naming conventions to meet those that are already established within this repository. You even said that you don't care about it. They told you they wanted to see a change to the verbiage already in use, which you flat out refused.

You randomly mentioning Torvald does nothing for you...You haven't apologized for blowing up on people that wanted some change, but were in no way rude to you. If you are claiming that you acted like Torvald himself, then yes; you have acted like him so far.

@OdinVex
Copy link

OdinVex commented Dec 11, 2023

Because you ARE re-hashing things, "I posted a working solution that could be backported to earlier stable versions, worked GUI and WebUI, they didn't want it. Closed the PR. Deluge is still apparently the only one to get it right about displaying externally-detected IP addresses. I meet less toxic devs working on the Linux Kernel. shrug"

^If that is not re-hashing something, it explains; why you don't understand normal logic^

That was from yesterday, a follow-up, or did you miss the timestamp?

You would have had to delete them yourself, GitHub doesn't allow others to delete your comments for you. It just sounds like you are trying to shift the blame for being rude.

It wasn't my posts missing. Again, I'm not the only one who read them.

So far the only one acting like a child on a public PR request, is you....

*yawn*

You were being rude, because people asked you to change your naming conventions to meet those that are already established within this repository. You even said that you don't care about it. They told you they wanted to see a change to the verbiage already in use, which you flat out refused.

I said I didn't care if they wanted to change it, that the choice was theirs if they wished, I specifically told them they could use it as they wished, you're conveniently not mentioning any of that.

You randomly mentioning Torvald does nothing for you...You haven't apologized for blowing up on people that wanted some change, but were in no way rude to you. If you are claiming that you acted like Torvald himself, then yes; you have acted like him so far.

At this point, blow it out your end. I wasn't claiming that I was acting like Torvald, I said I would rather work with someone like Torvald's old behavior (mostly because he simply cared about the code). Do whatever the you want with the PR or code, I don't care. Don't bother quoting/replying/naming me, I'm just going to ignore the repo at this point.

@ZaxLofful
Copy link

ZaxLofful commented Dec 11, 2023

I hope your ass blows out, then it would match your personality....Egomanic just like Torvald that goes on a petty power trips...Submits a PR then deletes his own code out of spite....Just to bring it back out of embarrassment.

Then tries to keep his ego intact by saying "I don't care", when the embarrassment and bringing back the code proves the opposite is true.

Edit: Hopefully that loser actually stays away like he claims.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request GUI GUI-related issues/changes
Projects
None yet
Development

No branches or pull requests

6 participants