Build dependency requirement clarification - qt5 svg

[userdocs]

I would like to query the need for this particular dependency.

libqt5svg5-dev / https://github.com/qt/qtsvg documented here https://github.com/qbittorrent/qBittorrent/wiki/Compilation:-Debian-and-Ubuntu#qt-libraries

I do not use this dependency to build my static binaries and for the relevant part of my build process.

qtbase > qtools > libtorrent > qbittorrent

I get no warnings, build errors, log messages or noticeable issues for the lack of this documented dependency.

https://packages.ubuntu.com/focal/qbittorrent < No! not a listed dependency

https://pkgs.alpinelinux.org/package/edge/testing/x86_64/qbittorrent-nox < No! not a listed dependency

https://www.archlinux.org/packages/community/x86_64/qbittorrent/ < Yes! a listed dependency

Can we clarify if this is needed and why, as currently don't understand if i need it or not.

edit: i'd consider it was a gui dependency and not a nox dependency, but neither Debian or ubuntu list it for the gui installation, so it confuses the matter further.

[FranciscoPombal]

You may be right. It is possible that this package is no longer required as a build dependency. I managed to build and run successfully after uninstalling that package and applying this patch on Ubuntu 18.04:

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 6709fbf37..93040baf2 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -60,7 +60,7 @@ include_directories(${CMAKE_CURRENT_SOURCE_DIR})
 add_subdirectory(base)
 
 if (GUI)
-    find_package(Qt5 ${minQtVersion} REQUIRED COMPONENTS Widgets Svg)
+    find_package(Qt5 ${minQtVersion} REQUIRED COMPONENTS Widgets)
     if (CMAKE_SYSTEM_NAME STREQUAL "Darwin")
         find_package(Qt5 ${minQtVersion} REQUIRED COMPONENTS MacExtras)
     elseif (CMAKE_SYSTEM_NAME STREQUAL "Windows")

Soon I will test on Windows.

For reference, libqt5svg5-dev file list on 18.04/bionic (for 20.04/focal it's exactly the same): https://packages.ubuntu.com/bionic/amd64/libqt5svg5-dev/filelist

[userdocs]

@FranciscoPombal I have some more insights into this regarding boost deps as well.

Currently documented dependencies are libboost-dev libboost-system-dev libboost-chrono-dev libboost-random-dev

What I found is that when I use b2 to build libtorrent (statically linked on this example) two files are created, libtorrent.a and libboost_system.a

I decided to apply the method i used with the python binding where I do not build boost libs and it works. There is no reason to actually build any boost libs when building libtorrent and qbittorrent from source when using b2.

The below commands will demonstrate the principle

zlib/openssl

from source or apt

boost

1: create b2 and 2: create headers we need.

cd $HOME
wget -qO $HOME/boost_1_74_0.tar.gz "https://dl.bintray.com/boostorg/release/1.74.0/source/boost_1_74_0.tar.gz"
tar xf $HOME/boost_1_74_0.tar.gz
cd $HOME/boost_1_74_0
./bootstrap.sh

Note: b2 also provides the option to build only required modules using --with-system. This greatly speeds up the process. I tested with this below command and it worked as a more generic approach. but it is an additional step not really required.

b2 --with-system variant=release threading=multi link=static install --prefix="$HOME"

Libtorrent

cd $HOME
git clone $HOME/libtorrent
cd $HOME/libtorrent
export BOOST_ROOT=$HOME/boost_1_74_0
export BOOST_INCLUDEDIR=$HOME/boost_1_74_0
export BOOST_BUILD_PATH=$HOME/boost_1_74_0
$HOME/boost_1_74_0/b2 -j$(nproc) cxxstd=14 crypto=openssl variant=release link=static install --prefix=$HOME

qtbase / qttools

qtbase/qtools from source or apt

qbittorrent

cd $HOME
git clone URL $HOME/qbittorrent
cd $HOME/qbittorrent
./configure --with-boost="$HOME/boost_1_74_0" --with-boost-libdir="$HOME/lib" CXXFLAGS="-std=c++14" libtorrent_LIBS="-L$HOME/lib -l:libtorrent.a" libtorrent_CFLAGS="-I$HOME/include" --disable-gui --prefix=$HOME
make
make install

Conclusion?

boost_system is the only required dependency and the above method demonstrates a significant simplification of the build process

[jagannatharjun]

on windows at least, if you build a static build without the SVG plugin, no icon will load.

[userdocs]

Is that the desktop? for the linux builds in question here are nox versions.

If it's a desktop specific dependency (possibly OS specific) that will be good to establish.

can you provide a screenshot of the issue so I can compare my linux builds

[FranciscoPombal]

My testing above was done with GUI on Ubuntu. On Windows, it is only possible to build with GUI.

Like @jagannatharjun says, it does seem to be necessary on Windows. No idea about macOS.
I wonder if this is possible on Ubuntu due to some kind of packaging oddity on that particular distro. Doesn't seem worth it to special-case this.