Fix mono_t2.m not returning offset value and not using it in plot #490
Conversation
|
@agahkarakuzu do you think this PR should be quickly integrated considering our other user in #492? |
|
@mathieuboudreau adding an optional field dynamically may be the only source of potential issue I can think off the top of my head. Can you test this in GUI? My MATLAB licence is behaving. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #490 +/- ##
==========================================
- Coverage 47.34% 46.51% -0.83%
==========================================
Files 260 260
Lines 8667 8675 +8
==========================================
- Hits 4103 4035 -68
- Misses 4564 4640 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Due to limited time on my side, I cannot do the extended tests (saving/loading of models, etc.) since we do not need this functionality at the moment. I have verified that this works as expected for doing the fits, though.
For this reason, I marked the PR as a draft.
Purpose
Describe the problem or feature in addition to a link to the issues.
Fixes #489 upstream such that offset fit result is propagated and the plot equation & fit is consistent with its options.
Approach
How does this change address the problem?
Write offset to returned fit results struct if model fits with offset.
Maybe consider returning offset = 0 if no offset was used to maintain structure of output.
equation() was changed to include the offset in the returned equation.
plot() was changed to print offset in title if it's present.
Open Questions and Pre-Merge TODOs
Use github checklists. When solved, check the box and explain the answer.
Review that changed source files/lines are related to the pull request/issue
If any files/commits were accidentally included, cherry-pick them into another branch.
Review that changed source files/lines were not accidentally deleted
Fix appropriately if so.
Test new features or bug fix
If not implemented/resolved adequately, solve it or inform the developer by requesting changes in your review.
Preferably, set breakpoints in the locations that the code was changed and follow allong line by line to see if the code behaves as intended.
Manual GUI tests (general)
Specifications