Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono_t2 model does not output or plot Offset value if options.OffsetTerm = true #489

Open
gabuzi opened this issue Sep 27, 2023 · 0 comments · May be fixed by #490
Open

mono_t2 model does not output or plot Offset value if options.OffsetTerm = true #489

gabuzi opened this issue Sep 27, 2023 · 0 comments · May be fixed by #490

Comments

@gabuzi
Copy link

gabuzi commented Sep 27, 2023

If I use the mono_t2 model to fit t2 maps and use the OffsetTerm in the model, the results do not contain any information about the OffsetTerm.

This leads to inconsistencies. For example, using plotModel with data where there may be a significant offset present, there is a systematic discrepancy between data and fit. Neither FitResults nor equation() do consider the offset.

Expected Behavior

If OffsetTerm is used in mono_t2, it should propagate to the fit results and be considered in the plot.

Actual Behavior

  • the value of the offset term is not present in the fit results struct
  • the equation() function does not consider the offset term either and returns the equation without offset, which is equivalent to offset = 0
  • plotModel() also does not consider the offset, such that the behavior is as if offset = 0

Steps to Reproduce the Problem

  1. acquire T2 data at low SNR
  2. use mono_t2 with OffsetTerm enabled
  3. look at FitResults: no offset value present. use plotModel(). the offset is not considered in the plot.

Specifications

  • Version: 2.4.2
  • Platform: windows with matlab 2023b
  • Subsystem: ?
gabuzi added a commit to gabuzi/qMRLab that referenced this issue Sep 27, 2023
gabuzi added a commit to gabuzi/qMRLab that referenced this issue Sep 27, 2023
@gabuzi gabuzi linked a pull request Sep 27, 2023 that will close this issue
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant