Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating some of LiberTEM features #939

Open
CSSFrancis opened this issue Jun 6, 2023 · 3 comments
Open

Integrating some of LiberTEM features #939

CSSFrancis opened this issue Jun 6, 2023 · 3 comments
Labels
won't fix yet Issues that will be dealt with post 1.0.0

Comments

@CSSFrancis
Copy link
Member

Is your feature request related to a problem? Please describe.
LiberTEM has a lot of features which pyxem has been lacking such as SSB Pyctography. It might be very useful to integrate or at least create a workflow which either:

  1. Lightly wraps the LiberTEM functions allowing people to download LiberTEM as an optional dependency for those operations.
  2. Provide notebooks showing how to translate the data from one source to the next.

As both packages have pretty similar dask based workflows this should add significant new features with little work and gives a bit more continuity between workflows.

Describe the solution you'd like

I'm open to suggestions from people as to the best way to do this. Particularly @uellue if you have any insight into the best way to do this I would love some suggestions!

It seems like LiberTEM has lots of functionality where pyxem is lacking so some collaboration would be useful!

@CSSFrancis
Copy link
Member Author

@nhagopian You have been using both packages a little bit interchangeably so any insight you have would be useful.

@pc494
Copy link
Member

pc494 commented Jan 26, 2024

@CSSFrancis - This is probably a post 1.0.0 job isn't it?

@CSSFrancis
Copy link
Member Author

@pc494 Yes, I also think it would probably be better to have this as an tutorial rather than a new feature

@pc494 pc494 added the won't fix yet Issues that will be dealt with post 1.0.0 label Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
won't fix yet Issues that will be dealt with post 1.0.0
Projects
None yet
Development

No branches or pull requests

2 participants