Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify attribute and class naming #65

Open
pnuu opened this issue May 11, 2020 · 0 comments
Open

Clarify attribute and class naming #65

pnuu opened this issue May 11, 2020 · 0 comments

Comments

@pnuu
Copy link
Member

pnuu commented May 11, 2020

The naming of attributes and classes need clarifying.

  • MoveItBase.notifier and MoveItBase.watchman handle the changes in the configuration file. This should have indication of their use
  • server.reload_config() has similarly named kwargs notifier_builder=None and manager=RequestManager that are used for detecting new files. The naming should indicate this. In addition, these are never used in any of the Trollmoves scripts, so maybe the could be removed altogether?
  • Both server.py and client.py implement EventHandler, only the one in server.py is used. Maybe this should be in utils.py?
  • MoveItBase has an attribute self._np, which is only used by the MoveItClient class in bin/move_it_client.py, but the publisher is stopped in move_it_base.MoveItBase.chains_stop(). This should be renamed (self._noisy_publisher?) and the whole class moved to trollmoves/client.py
  • MoveItServer in bin/move_it_server.py should be moved to trollmoves/server.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant