Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate np.nan_to_num usage in Rayleigh correction #160

Open
djhoese opened this issue Oct 6, 2022 · 0 comments
Open

Investigate np.nan_to_num usage in Rayleigh correction #160

djhoese opened this issue Oct 6, 2022 · 0 comments
Assignees

Comments

@djhoese
Copy link
Member

djhoese commented Oct 6, 2022

As discussed on slack and #159, there used to be a np.nan_to_num call applied to the correction array returned by Rayleigh correction. The idea was that if the correction calculations failed we should just not apply any correction. In some cases it looks better though to mask the pixels entirely (by keeping them NaN). This allows the user to determine what they want to do with the correction (mask or make 0).

The question is, what cases was @adybbroe coding for in PR #140 when np.nan_to_num was first added? And do the other np.nan_to_num calls added in that PR suffice for those cases (extreme angles)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants