Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of has_keys_with_prefix Method #103

Open
Amerikranian opened this issue May 11, 2024 · 1 comment
Open

Removal of has_keys_with_prefix Method #103

Amerikranian opened this issue May 11, 2024 · 1 comment

Comments

@Amerikranian
Copy link

Amerikranian commented May 11, 2024

Hi,

I was looking through the source and saw that has_keys_with_prefix is deprecated and will be removed. Could you elaborate as to why? This seems very useful for if you wanted to fetch a random word of given length from the trie (I myself just so happen to need to do this). Using iterkeys is unacceptable, as it is too slow and gives extraneous information--I only want to know if the given prefix forms a valid path through a tree.

@BoboTiG
Copy link
Contributor

BoboTiG commented May 11, 2024

🤔 It was deprecated in fc71f2a.

I have no strong opinion TBH.

I'll need more inputs from others in order to either:

  1. actually remove the method
  2. keep the method, and remove the deprecation warning
  3. do nothing, keep the current state

I'm OK with option 2 personally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants