Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
carmocca committed Dec 17, 2021
1 parent 8508cce commit 62f1e82
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Expand Up @@ -293,10 +293,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

### Fixed

- Fixed a bug to disable logging hyperparameters in logger if there are no hparams ([#11105](https://github.com/PyTorchLightning/pytorch-lightning/issues/11105))
- Fixed security vulnerabilities CVE-2020-1747 and CVE-2020-14343 caused by the `PyYAML` dependency ([#11099](https://github.com/PyTorchLightning/pytorch-lightning/pull/11099))


-
- Fixed a bug to disable logging hyperparameters in logger if there are no hparams ([#11105](https://github.com/PyTorchLightning/pytorch-lightning/issues/11105))


- Avoid the deprecated `onnx.export(example_outputs=...)` in torch 1.10 ([#11116](https://github.com/PyTorchLightning/pytorch-lightning/pull/11116))
Expand Down
2 changes: 1 addition & 1 deletion pytorch_lightning/core/saving.py
Expand Up @@ -344,7 +344,7 @@ def load_hparams_from_yaml(config_yaml: str, use_omegaconf: bool = True) -> Dict
return {}

with fs.open(config_yaml, "r") as fp:
hparams = yaml.load(fp, Loader=yaml.UnsafeLoader)
hparams = yaml.full_load(fp)

if _OMEGACONF_AVAILABLE:
if use_omegaconf:
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Expand Up @@ -4,7 +4,7 @@ numpy>=1.17.2
torch>=1.7.*
future>=0.17.1 # required for builtins in setup.py
tqdm>=4.41.0
PyYAML>=5.1
PyYAML>=5.4
fsspec[http]>=2021.05.0, !=2021.06.0
tensorboard>=2.2.0
torchmetrics>=0.4.1
Expand Down
2 changes: 0 additions & 2 deletions tests/loggers/test_csv.py
Expand Up @@ -12,7 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
import os
from argparse import Namespace
from unittest.mock import MagicMock

import pytest
Expand Down Expand Up @@ -95,7 +94,6 @@ def test_file_logger_log_hyperparams(tmpdir):
"bool": True,
"dict": {"a": {"b": "c"}},
"list": [1, 2, 3],
"namespace": Namespace(foo=Namespace(bar="buzz")),
"layer": torch.nn.BatchNorm1d,
}
logger.log_hyperparams(hparams)
Expand Down

0 comments on commit 62f1e82

Please sign in to comment.