[v1.7.0] Release Tracker #45592

seemethere · 2020-09-30T18:39:15Z

We cut a release branch for the 1.7.0 release.

Our plan from this point is roughly:

Phase 1 (until 10/13): work on finalizing the release branch
Phase 2 (after 10/13): perform extended integration/stability/performance testing based on Release Candidate builds.

This issue is for tracking cherry-picks to the release branch.

Cherry-Pick Criteria

Phase 1 (until 10/13):

Only low-risk changes may be cherry-picked from master:

Fixes to regressions against PyTorch 1.0+
Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
Fixes to new features being introduced in this release
Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries
Test/CI fixes or improvements
Documentation improvements
Release branch specific changes (e.g. change version identifiers, remove/hide features that aren’t ready for release)

Any other change requires special dispensation from the release managers (currently @malfet, @seemethere, @gchanan). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.

Phase 2 (after 10/13):

Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are:

Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks

This will likely require a discussion with the larger release team over VC or Slack.

Cherry-Pick Process

Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).
Create (but do not land) a PR against the release branch. Note that you should use the normal github workflow for this; ghstack does not support release branches.
Make a request below with the following template:

Link to landed master PR (if applicable):
Link to release branch PR:
Criteria Category:

Someone from the release team will reply with approved / denied or ask for more information
If approved, someone from the release team will merge your PR once the tests pass. NOTE: do not land the release branch PR yourself. Our normal landing tools (ghimport, phabricator, etc.) do not work on the release branch.

The text was updated successfully, but these errors were encountered:

zou3519 · 2020-09-30T19:16:29Z

Link to landed master PR (if applicable): n/a, release-specific change
Link to release branch PR: #45571
Criteria Category: Release branch specific changes: remove/hide features that aren’t ready for release

@seemethere: accepted

Krovatkin · 2020-09-30T19:31:30Z

Link to landed master PR (if applicable): #45546
Link to release branch PR: #45591
Criteria Category: special dispensation : Profiling Executor and Tensor Expressions are two features that shareholders (@soumith, @ngimel, @dzhulgakov etc) decided should go into 1.7. Unfortunately, we narrowly missed the deadline fixing a small oversight in one of the test configurations.

--
@malfet: merged

anjali411 · 2020-09-30T20:23:44Z

Link to landed master PR: #45461
Link to release branch PR: #45602
Criteria Category: silent correctness. Before this branch, the functions unaudited for complex backward returned incorrect result. After this PR, a RuntimeError is thrown in forward clearly stating that complex backward is not supported for the operator yet.

--
@malfet: merged

suo · 2020-09-30T23:40:41Z

Link to release branch PR: #45628
Criteria category: Release branch specific changes: remove/hide features that aren't ready for release.

--
@malfet: merged

jamesr66a · 2020-10-01T00:14:11Z

Link to release branch PR: #45631
Criteria Category: Release branch specific changes: remove/hide features that aren’t ready for release

--
@malfet: merged

robieta · 2020-10-01T00:57:18Z

Link to landed master PR: #45586
Link to release branch PR: #45601
Criteria Category: special dispensation : Callgrind collection is an important aspect of the benchmarking utils beta launch. (CC @ngimel @ezyang @dzhulgakov) Original PR narrowly missed the cut, and had to be reverted and re-landed today due to a test breakage. Fortunately it is isolated to benchmark utils and as a result the interaction radius should be small.

@malfet: Binary size diff is less than 4Kb, merged.

mrshenli · 2020-10-02T14:56:17Z

Link to landed master PR: #45553
Link to release branch PR: #45738
Criteria Category: Documentation improvements: Advise users to use a more widely-adopted conda channel and pin the libuv version to the one that we have tested (1.39).

--
@malfet: merged

mrshenli · 2020-10-02T14:57:47Z

Link to landed master PR: #45554
Link to release branch PR: #45739
Criteria Category: Fixes to new features being introduced in this release: Make sure that users don't have to install libuv if they don't need the distributed package.

--
@malfet: merged

QueensGambit · 2020-10-02T16:21:07Z

Link to release master PR: #45736
Criteria Category: Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries

--
@malfet: Please land it in master first

BowenBao · 2020-10-02T18:12:07Z

Link to landed master PR: #44920
Link to release branch PR: #45755
Criteria Category: Fixes to new features being introduced in this release: Fix dim_param support for ONNX export with shape inference, along with fixes to shape propagation bugs in other code that are discovered. This PR is crucial for ONNX export in 1.7, unfortunately it missed the cut by a few hours.

--
merged

neginraoof · 2020-10-02T18:36:06Z

Link to landed master PR: #44693
Link to release branch PR: #45756
Criteria Category: Fixes ONNX export of embedding bag operator with dynamically provided arguments: offsets and weights. Enables ONNX export of DLRM model. This PR is crucial for ONNX export in 1.7.

--
merged

osalpekar · 2020-10-02T18:50:53Z

Link to landed master PR: #45543
Link to release branch PR: #45758
Criteria Categrory: Documentation - PyTorch Distributed exposes a Python API for a distributed key-value store, but there were no public docs for this. This PR adds those public docs.

--
@malfet: merged

bdhirsh · 2020-10-02T19:03:56Z

Link to landed master PR (if applicable): #45587 and #45588
Link to release branch PR: #45759
Criteria Category: Fixes to new features being introduced in this release: Un-defaulting a new parameter to the smooth_l1_loss_backward function, which is how we handle all other backwards function inputs and would otherwise require deprecating. Fixed some incorrect changes to the documentation of smooth_l1_loss.

@malfet: resolved merged conflict, waiting for CI
@gchanan: merged

xwang233 · 2020-10-02T20:47:45Z

Link to landed master PR (if applicable): #45729
Link to release branch PR: #45770
Criteria Category: Fixes to new features being introduced in this release.

A user just reported seeing this #45769. It would be nice that we have this minor information printing bug be fixed in the release.

--
@malfet: merged

anjali411 · 2020-10-05T15:35:02Z

Link to landed master PR: N/A
Link to release branch PR: #45839
Criteria Category: silent correctness. Disabled backward for torch.angle.

--
@malfet: merged

gchanan · 2020-10-05T22:43:56Z

Link to landed master PR: N/A
Link to release branch PR: #45859
Criteria Category: Release branch specific changes -- makes the compatibility tests pass against 1.6.0.

Merged

xta0 · 2020-10-06T05:55:09Z

Link to landed master PR: #45651, #45677, #45798
Link to release branch PR: #45891
Criteria Category:[iOS][CI]

Fix the iOS dev cert issue for CI jobs and nightlies.
Solve the XCode12 user issue - Xcode 12 Build Error: LibTorch/install/lib/libpytorch_qnnpack.a , building for iOS, but linking in object file built for macOS #44143

--
@malfet: merged

vkuzo · 2020-10-06T16:04:59Z

Link to landed master PR: #45848
Link to release branch PR: ebe8b21
Criteria category: Documentation improvements - adds an API summary to the Quantization documentation

Working with @malfet to figure out how this ended up merged without a PR, I probably messed up a git step.

xwang233 · 2020-10-06T21:15:41Z

Link to landed master PR (if applicable): #45889
Link to release branch PR: #45924
Criteria Category: 4. Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries

This may improve the performance on Ampere GeForce 3080 and 3090, if pytorch is compiled with cuda 11.1.

--
@malfet: this sounds a bit vague, can you please share some benchmark results?

zasdfgbnm · 2020-10-08T00:10:55Z

Link to landed master PR (if applicable): #46001
Link to release branch PR: #46042
Criteria Category: 2. Critical fixes for silent correctness #45724

@malfet: merged

adampauls · 2020-10-08T03:24:14Z

Link to landed master PR (if applicable): #43532
Link to release branch PR: #46014
Criteria Category:4. Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries

t-vi · 2020-10-08T15:55:48Z

Once it's landed, probably #46028 (high priority bug fix, should apply to 1.7 as well)

Flamefire · 2020-10-15T11:18:23Z

Link to landed master PR (if applicable): #46315
Link to release branch PR: #46388
Criteria Category: Test/CI fixes or improvements

Avoid error when using Python 3.9 (e.g. clang-tidy CI)

@malfet: merged and thank you for the pick

albanD · 2020-10-15T17:51:59Z

Link to landed master PR (if applicable): #46406
Link to release branch PR: #46407
Criteria Category: Mitigation for #46242 that replaces the internal error by a helpful message.

albanD · 2020-10-15T18:45:06Z

Link to landed master PR (if applicable): #46397
Link to release branch PR: #46408
Criteria Category: Fix wrong error message content for torch.scatter. It is a nice to have but not strictly needed.

Merged

gchanan · 2020-10-15T20:59:32Z

Link to landed master PR (if applicable): #46335
Link to release branch PR: #46418
Criteria Category: Test/CI fixes or improvements. Should allow clang-tidy to pass on release branch.

Merged

gchanan · 2020-10-15T21:04:31Z

Link to landed master PR (if applicable): #45638
Link to release branch PR: #46419
Criteria Category: Test/CI fixes or improvements. Should fix cuda fuser test failures on release branch.

Merged

SplitInfinity · 2020-10-15T21:29:04Z

Link to landed master PR: #45940
Link to release branch PR: #46422
Criteria category: Fix for a crash in an uncommonly used user-facing code path in TorchScript

@malfet: merged

gchanan · 2020-10-15T21:35:45Z

Link to landed master PR: N/A
Link to release branch PR: #46425
Criteria category: Release branch specific changes, fix CI for XLA.

Merged

robieta · 2020-10-15T23:36:42Z

Link to landed master PR: #46023
Link to release branch PR: #46403
Criteria category: Special Dispensation several key tweaks to benchmark utils.

ZolotukhinM · 2020-10-16T08:31:52Z

Link to landed master PR: #46446
Link to release branch PR: #46453
Criteria category: fixes a crash

gchanan · 2020-10-16T17:24:25Z

Link to landed master PR: N/A
Link to release branch PR: #46478
Criteria category: Release branch specific changes, fix CI for backwards compatibility

merged

Krovatkin · 2020-10-16T23:10:42Z

Link to landed master PR: #46479
Link to release branch PR: #46621
Criteria category: Critical fixes (increased memory consumption in profiling mode)

@malfet: merged

ZolotukhinM · 2020-10-19T18:16:25Z

Link to landed master PR: #46446, #46500, #46482
Link to release branch PR: #46513 (combines all three commits)
Criteria category: fixes incorrect behavior in fused aten::cat

@malfet: merged

suo · 2020-10-19T19:33:12Z

Link to release branch PR: #46556
Link to master PR: #46556
Criteria category: fixes test breakage when built with BUILD_TEST=0 (which the RC builds do)

@malfet: Please create this change in master first, as it is not specific to RC PRs

albanD · 2020-10-22T15:42:52Z

Link to landed master PR: #46673
Link to release branch PR: #46718
Criteria category: Remove public functions that should not be public called valgrind_*.

@malfet: merged

albanD · 2020-10-22T15:43:33Z

Link to landed master PR: #46680
Link to release branch PR: #46719
Criteria category: Remove public functions that should not be public for __torch_function__ feature

@malfet: merged

albanD · 2020-10-23T14:38:30Z

Link to landed master PR: #46676
Link to release branch PR: #46765
Criteria category: Remove public functions that should not be public add_relu.

@malfet: merged

brianjo · 2020-10-26T21:23:38Z

Link to release branch PR: #46845
Criteria category: Documentation improvements.

osalpekar · 2020-10-26T22:10:22Z

Link to landed master PR: #46856
Link to release branch PR: #46879
Criteria category: Docs fixes

z-a-f · 2020-10-26T23:29:34Z

Link to landed master PR: #46858
Link to release branch PR: #46890
Criteria Category: Documentation improvement: Quantization docs had a specific version to describe unsupported features. Changed to more general wording.

seemethere · 2020-10-27T22:19:56Z

Hey everyone, 1.7.0 has been released so I'm going to close this.

Thank you everyone for the work towards getting v1.7.0 out of the door!

z-a-f · 2020-11-02T18:44:13Z

Link to landed master PR: #46858
Link to release branch PR: #46890
Criteria Category: Documentation improvement: Quantization docs had a specific version to describe unsupported features. Changed to more general wording.

@seemethere If this PR was not merged, is there still a way to add it?

seemethere added the oncall: releng In support of CI and Release Engineering label Sep 30, 2020

seemethere pinned this issue Sep 30, 2020

pytorch deleted a comment from Krovatkin Sep 30, 2020

subramen unpinned this issue Oct 1, 2020

seemethere pinned this issue Oct 1, 2020

colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 2, 2020

xta0 unpinned this issue Oct 2, 2020

malfet pinned this issue Oct 2, 2020

gchanan added this to the 1.7.0 milestone Oct 15, 2020

wayi1 unpinned this issue Oct 16, 2020

gchanan pinned this issue Oct 16, 2020

wayi1 unpinned this issue Oct 21, 2020

malfet pinned this issue Oct 23, 2020

stas00 mentioned this issue Oct 25, 2020

[test] tests/test_modeling_deberta.py breaks on pytorch-nightly huggingface/transformers#8022

Closed

seemethere closed this as completed Oct 27, 2020

pytorch locked as resolved and limited conversation to collaborators Oct 27, 2020

seemethere unpinned this issue Oct 27, 2020

[v1.7.0] Release Tracker #45592

[v1.7.0] Release Tracker #45592

Comments

seemethere commented Sep 30, 2020 • edited by gchanan

Cherry-Pick Criteria

Cherry-Pick Process

zou3519 commented Sep 30, 2020 • edited by seemethere

Krovatkin commented Sep 30, 2020 • edited by malfet

anjali411 commented Sep 30, 2020 • edited by malfet

suo commented Sep 30, 2020 • edited by malfet

jamesr66a commented Oct 1, 2020 • edited by malfet

robieta commented Oct 1, 2020 • edited by malfet

mrshenli commented Oct 2, 2020 • edited by malfet

mrshenli commented Oct 2, 2020 • edited by malfet

QueensGambit commented Oct 2, 2020 • edited by malfet

BowenBao commented Oct 2, 2020 • edited by malfet

neginraoof commented Oct 2, 2020 • edited by malfet

osalpekar commented Oct 2, 2020 • edited by malfet

bdhirsh commented Oct 2, 2020 • edited by malfet

xwang233 commented Oct 2, 2020 • edited by malfet

anjali411 commented Oct 5, 2020 • edited by malfet

gchanan commented Oct 5, 2020 • edited

xta0 commented Oct 6, 2020 • edited by malfet

vkuzo commented Oct 6, 2020

xwang233 commented Oct 6, 2020 • edited by malfet

zasdfgbnm commented Oct 8, 2020 • edited by malfet

adampauls commented Oct 8, 2020

t-vi commented Oct 8, 2020 • edited

Flamefire commented Oct 15, 2020 • edited by malfet

albanD commented Oct 15, 2020 • edited

albanD commented Oct 15, 2020 • edited by gchanan

gchanan commented Oct 15, 2020 • edited

gchanan commented Oct 15, 2020 • edited

SplitInfinity commented Oct 15, 2020 • edited by malfet

gchanan commented Oct 15, 2020 • edited

robieta commented Oct 15, 2020

ZolotukhinM commented Oct 16, 2020

gchanan commented Oct 16, 2020 • edited

Krovatkin commented Oct 16, 2020 • edited by malfet

ZolotukhinM commented Oct 19, 2020 • edited by malfet

suo commented Oct 19, 2020 • edited by malfet

albanD commented Oct 22, 2020 • edited by malfet

albanD commented Oct 22, 2020 • edited by malfet

albanD commented Oct 23, 2020 • edited by malfet

brianjo commented Oct 26, 2020

osalpekar commented Oct 26, 2020

z-a-f commented Oct 26, 2020

seemethere commented Oct 27, 2020

z-a-f commented Nov 2, 2020

seemethere commented Sep 30, 2020 •

edited by gchanan

zou3519 commented Sep 30, 2020 •

edited by seemethere

Krovatkin commented Sep 30, 2020 •

edited by malfet

anjali411 commented Sep 30, 2020 •

edited by malfet

suo commented Sep 30, 2020 •

edited by malfet

jamesr66a commented Oct 1, 2020 •

edited by malfet

robieta commented Oct 1, 2020 •

edited by malfet

mrshenli commented Oct 2, 2020 •

edited by malfet

mrshenli commented Oct 2, 2020 •

edited by malfet

QueensGambit commented Oct 2, 2020 •

edited by malfet

BowenBao commented Oct 2, 2020 •

edited by malfet

neginraoof commented Oct 2, 2020 •

edited by malfet

osalpekar commented Oct 2, 2020 •

edited by malfet

bdhirsh commented Oct 2, 2020 •

edited by malfet

xwang233 commented Oct 2, 2020 •

edited by malfet

anjali411 commented Oct 5, 2020 •

edited by malfet

gchanan commented Oct 5, 2020 •

edited

xta0 commented Oct 6, 2020 •

edited by malfet

xwang233 commented Oct 6, 2020 •

edited by malfet

zasdfgbnm commented Oct 8, 2020 •

edited by malfet

t-vi commented Oct 8, 2020 •

edited

Flamefire commented Oct 15, 2020 •

edited by malfet

albanD commented Oct 15, 2020 •

edited

albanD commented Oct 15, 2020 •

edited by gchanan

gchanan commented Oct 15, 2020 •

edited

gchanan commented Oct 15, 2020 •

edited

SplitInfinity commented Oct 15, 2020 •

edited by malfet

gchanan commented Oct 15, 2020 •

edited

gchanan commented Oct 16, 2020 •

edited

Krovatkin commented Oct 16, 2020 •

edited by malfet

ZolotukhinM commented Oct 19, 2020 •

edited by malfet

suo commented Oct 19, 2020 •

edited by malfet

albanD commented Oct 22, 2020 •

edited by malfet

albanD commented Oct 22, 2020 •

edited by malfet

albanD commented Oct 23, 2020 •

edited by malfet