Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uwsgi from application dependencies #682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Jun 5, 2020

uwsgi is installed by default using other means in the virtualenv
used by junction. There is no need to install uwsgi through the
application dependencies.

The support for uwsgi is flaky at best on Windows and works with
very limited functionality. Hence, this breaks development velocity
for people developing Junction on Windows.

Ref: #651

Closes #651

uwsgi is installed by default using other means in the virtualenv
used by junction. There is no need to install uwsgi through the
application dependencies.

The support for uwsgi is flaky at best on Windows and works with
very limited functionality. Hence, this breaks development velocity
for people developing Junction on Windows.

Ref: pythonindia#651

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun
Copy link
Member Author

Closing and reopening for satisfying Travis CI. 😞

@palnabarun palnabarun closed this Jun 5, 2020
@palnabarun palnabarun reopened this Jun 5, 2020
@sayanchowdhury
Copy link
Member

Just a wild guess, but won't squashing an empty commit also trigger the CI?

@palnabarun
Copy link
Member Author

@sayanchowdhury -- It should even if I amend the commits and force push. The problem is with Travis CI not even getting the events. 🤷‍♂️

@sayanchowdhury
Copy link
Member

Hmm, weird.

@ananyo2012
Copy link
Contributor

@palnabarun I think it will be good to move this to a separate requirements-prod.txt until we have a proper dependency management tool.

@palnabarun
Copy link
Member Author

I think it will be good to move this to a separate requirements-prod.txt until we have a proper dependency management tool.

Well, uwsgi is going to go away soon in the new setup. uwsgi is not related to the Junction application and should not be there in the project at all.

@ananyo2012
Copy link
Contributor

Isn't uswgi needed in production ?

@palnabarun
Copy link
Member Author

Isn't uswgi needed in production ?

Yes. It is, but not installed using this project's requirements.

@ananyo2012
Copy link
Contributor

Well it's good to have a separate prod-requirements.txt than to manually install production packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue while setting up in windows 10
3 participants