Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize fonts by only loading 3 by default instead of all kenney fonts #1844

Open
cspotcode opened this issue Aug 4, 2023 · 3 comments
Open

Comments

@cspotcode
Copy link
Collaborator

No description provided.

@pushfoo
Copy link
Member

pushfoo commented Aug 4, 2023

This may actually be a dupe of #1011, specifically this comment: #1011 (comment)

If it's not a dupe and merely an overlap, this issue should mention using three metric-compatible SIL open font license fonts.

@cspotcode
Copy link
Collaborator Author

I see

we should use the bundled font solution

Would you mind re-titling #1011 to say that, to describe briefly what must happen? Is the task to bundle 3 fonts and load them at startup?

@pushfoo
Copy link
Member

pushfoo commented Aug 4, 2023

Would you mind re-titling #1011 to say that, to describe briefly what must happen?

Done, along with some revisions to the ticket for clarity.

Is the task to bundle 3 fonts and load them at startup?

Yes, although the initial draft of the ticket was more conservative due to concerns about font licensing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants