Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite3: disallow using a sequence of params with named placeholders #118928

Closed
erlend-aasland opened this issue May 10, 2024 · 0 comments · Fixed by #118929
Closed

sqlite3: disallow using a sequence of params with named placeholders #118928

erlend-aasland opened this issue May 10, 2024 · 0 comments · Fixed by #118929
Assignees
@erlend-aasland
Labels
topic-sqlite3 type-feature A feature request or enhancement

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented May 10, 2024 •
edited by bedevere-app bot

Feature or enhancement

Follow-up of...:

Based on the discussion in the above linked Discourse topic, I propose to now issue a deprecation warning if sequences are used with named placeholders. The deprecation warning should inform that from Python 3.14 and onward, sqlite3.ProgrammingError will be raised instead.

3.14 dev is now opened, so let's convert the deprecation warning to a programming error sooner than later.

Linked PRs
@erlend-aasland erlend-aasland added type-feature A feature request or enhancement topic-sqlite3 labels May 10, 2024
@erlend-aasland erlend-aasland self-assigned this May 10, 2024
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue May 10, 2024
@erlend-aasland
pythongh-118928: sqlite3: disallow sequences of params with named pla…
b66f04a 
…ceholders

Follow-up of pythongh-101693.
@bedevere-app bedevere-app bot mentioned this issue May 10, 2024
Merged
@erlend-aasland erlend-aasland linked a pull request May 11, 2024 that will close this issue
gh-118928: sqlite3: disallow sequences of params with named placeholders #118929
Merged
erlend-aasland added a commit that referenced this issue May 14, 2024
@erlend-aasland @hugovk
gh-118928: sqlite3: disallow sequences of params with named placehold…
d8e0e00 
…ers (#118929)

Follow-up of gh-101693. The previous DeprecationWarning is replaced with 
raising sqlite3.ProgrammingError.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue May 20, 2024
@erlend-aasland
pythongh-118928: sqlite3: correctly bail if sequences of params are u…
4bde862 
…sed with named placeholders

Fix up post pythongh-118929.
@bedevere-app bedevere-app bot mentioned this issue May 20, 2024
Merged
erlend-aasland added a commit that referenced this issue May 20, 2024
@erlend-aasland
gh-118928: sqlite3: correctly bail if sequences of params are used wi…
af359ce 
…th named placeholders (#119197)
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue May 20, 2024
@erlend-aasland
pythongh-118928: Remove unneeded NEWS entry
c99f9d1 
The regression was never part of an official release.
@bedevere-app bedevere-app bot mentioned this issue May 20, 2024
Merged
erlend-aasland added a commit that referenced this issue May 20, 2024
@erlend-aasland
gh-118928: Remove unneeded sqlite3 NEWS entry (#119208)
1db4695 
The regression in d8e0e00 was never part of an official release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
topic-sqlite3 type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-118928: sqlite3: disallow sequences of params with named placeholders erlend-aasland/cpython
1 participant
@erlend-aasland