Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotImplemented is never tested with attribute assignment #118899

Closed
sobolevn opened this issue May 10, 2024 · 0 comments
Closed

NotImplemented is never tested with attribute assignment #118899

sobolevn opened this issue May 10, 2024 · 0 comments
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented May 10, 2024 •
edited by bedevere-app bot

Bug report

This issue adds tests for NoDefault and attribute assignment: #118895

But, we never had tests for the same thing of NotImplemented. I will add a test case for that.

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels May 10, 2024
@sobolevn sobolevn self-assigned this May 10, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue May 10, 2024
@sobolevn
pythongh-118899: Add tests for NotImplemented attribute access
49d3e6a
@bedevere-app bedevere-app bot mentioned this issue May 10, 2024
Merged
sobolevn added a commit that referenced this issue May 12, 2024
@sobolevn
gh-118899: Add tests for NotImplemented attribute access (#118902)
ec1398e
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 12, 2024
@sobolevn @miss-islington
pythongh-118899: Add tests for NotImplemented attribute access (pyt…
bccb0fa 
…honGH-118902)

(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app bedevere-app bot mentioned this issue May 12, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 12, 2024
@sobolevn @miss-islington
pythongh-118899: Add tests for NotImplemented attribute access (pyt…
351358b 
…honGH-118902)

(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app bedevere-app bot mentioned this issue May 12, 2024
Merged
sobolevn added a commit that referenced this issue May 12, 2024
@miss-islington @sobolevn
[3.12] gh-118899: Add tests for NotImplemented attribute access (GH…
76dc1bf 
…-118902) (#118969)

gh-118899: Add tests for `NotImplemented` attribute access (GH-118902)
(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this issue May 12, 2024
@miss-islington @sobolevn
[3.13] gh-118899: Add tests for NotImplemented attribute access (GH…
6e855b3 
…-118902) (#118968)

gh-118899: Add tests for `NotImplemented` attribute access (GH-118902)
(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn