Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement inspect.signature() for functools.cmp_to_key() result #118402

Closed
serhiy-storchaka opened this issue Apr 29, 2024 · 1 comment
Closed

Implement inspect.signature() for functools.cmp_to_key() result #118402

serhiy-storchaka opened this issue Apr 29, 2024 · 1 comment
Labels
3.13 bugs and security fixes type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Apr 29, 2024 •
edited by bedevere-app bot

Feature or enhancement

functools.cmp_to_key() returns a custom callable. inspect.signature() returns generic <Signature (*args, **kwargs)> raises a TypeError for the C implementation. The following PR makes it returning the same signature (<Signature (obj)>) for both Python and C implementations (currently it is returned for the Python implementation).

This issue is similar to #118285.

Linked PRs
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Apr 29, 2024
@serhiy-storchaka serhiy-storchaka mentioned this issue Apr 29, 2024
Closed
@serhiy-storchaka
Copy link
Member Author

Split the TypeError bug in a separate issue #118404.

@serhiy-storchaka serhiy-storchaka mentioned this issue Apr 29, 2024
Closed
@serhiy-storchaka serhiy-storchaka added the 3.13 bugs and security fixes label Apr 29, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Apr 30, 2024
@serhiy-storchaka
pythongh-118402: Fix inspect.signature() for functools.cmp_to_key() r…
10d3600 
…esult
@bedevere-app bedevere-app bot mentioned this issue Apr 30, 2024
Merged
serhiy-storchaka added a commit that referenced this issue Apr 30, 2024
@serhiy-storchaka
gh-118402: Fix inspect.signature() for functools.cmp_to_key() result (G…
17a8af9 
…H-118427)
SonicField pushed a commit to SonicField/cpython that referenced this issue May 8, 2024
@serhiy-storchaka @SonicField
pythongh-118402: Fix inspect.signature() for functools.cmp_to_key() r…
4381919 
…esult (pythonGH-118427)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka