Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newish main compile warning on Windows 64: debug, nogil #118305

Closed
terryjreedy opened this issue Apr 26, 2024 · 3 comments
Closed

Newish main compile warning on Windows 64: debug, nogil #118305

terryjreedy opened this issue Apr 26, 2024 · 3 comments
Labels
build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error

Comments

@terryjreedy
Copy link
Member

terryjreedy commented Apr 26, 2024

Bug report

C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\um\wingdi.h(118,1):
 warning C4005: 'ERROR': macro redefinition (compiling source file ..\Python\in
struction_sequence.c) [f:\dev\3x\PCbuild\_freeze_module.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\um\wingdi.h(118,1):
 warning C4005: 'ERROR': macro redefinition (compiling source file ..\Python\in
struction_sequence.c) [f:\dev\3x\PCbuild\pythoncore.vcxproj]

I am pretty sure this is new within the last month, but not new today. Does CI allow merging with such warnings?

EDIT: these are fixed, but replaced with those below.

@terryjreedy terryjreedy added type-bug An unexpected behavior, bug, or error OS-windows build The build process and cross-build labels Apr 26, 2024
@neonene
Copy link
Contributor

neonene commented Apr 28, 2024

Fixed by #118326. Sorry for missing this.

@terryjreedy
Copy link
Member Author

terryjreedy commented Apr 28, 2024

I verified that those two are fixed. Thank you. But now I get this:

f:\dev\3x\Python\optimizer_cases.c.h(1444,46): warning C4133: '=': incompatible
 types - from '_Py_UopsSymbol *' to '_PyInterpreterFrame *' (compiling source f
ile ..\Python\optimizer_analysis.c) [f:\dev\3x\PCbuild\_freeze_module.vcxproj]
f:\dev\3x\Python\optimizer_cases.c.h(1444,46): warning C4133: '=': incompatible
 types - from '_Py_UopsSymbol *' to '_PyInterpreterFrame *' (compiling source f
ile ..\Python\optimizer_analysis.c) [f:\dev\3x\PCbuild\pythoncore.vcxproj]

I am leaving this open for these.

@sobolevn
Copy link
Member

@terryjreedy this is a separate issue that is tracked in #118343

I think it is safe to close this one now :)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build OS-windows type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

3 participants