_Py_FinishPendingCalls() Doesn't Necessarily Run All Remaining Pending Calls

[ericsnowcurrently]

Bug report

Bug description:

In Python/ceval_gil.c, _Py_FinishPendingCalls() calls make_pending_calls() once. make_pending_calls() will fail with the first pending call that fails (returns a non-zero value), leaving any remaining pending calls in the queue. _Py_FinishPendingCalls() basically throws away the error and walks away.

Instead, _Py_FinishPendingCalls() should keep trying until there are no pending calls left in the queue.

(I found this while working on gh-110693.)

CPython versions tested on:

3.13

Operating systems tested on:

No response

Linked PRs

• gh-118297: Make Sure All Pending Calls Run in _Py_FinishPendingCalls() #118298