Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT CI is broken due to test_traceback & test_tracemalloc #118275

Closed
nineteendo opened this issue Apr 25, 2024 · 7 comments
Closed

JIT CI is broken due to test_traceback & test_tracemalloc #118275

nineteendo opened this issue Apr 25, 2024 · 7 comments
Labels
performance Performance or resource usage

Comments

@nineteendo
Copy link
Contributor

nineteendo commented Apr 25, 2024

Looks like something broke: https://github.com/python/cpython/actions/runs/8823706356/job/24224733399#step:8:9723

======================================================================
FAIL: test_env_var_invalid (test.test_tracemalloc.TestCommandLine.test_env_var_invalid) (nframe=-1)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_tracemalloc.py", line 957, in test_env_var_invalid
    self.check_env_var_invalid(nframe)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/home/runner/work/cpython/cpython/Lib/test/test_tracemalloc.py", line 951, in check_env_var_invalid
    self.fail(f"unexpected output: {stderr!a}")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: unexpected output: b"aarch64-binfmt-P: Could not open '/lib/ld-linux-aarch64.so.1': No such file or directory\n"

======================================================================
FAIL: test_env_var_invalid (test.test_tracemalloc.TestCommandLine.test_env_var_invalid) (nframe=1073741824)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_tracemalloc.py", line 957, in test_env_var_invalid
    self.check_env_var_invalid(nframe)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/home/runner/work/cpython/cpython/Lib/test/test_tracemalloc.py", line 951, in check_env_var_invalid
    self.fail(f"unexpected output: {stderr!a}")
    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: unexpected output: b"aarch64-binfmt-P: Could not open '/lib/ld-linux-aarch64.so.1': No such file or directory\n"

======================================================================
ERROR: test_encoded_file (test.test_traceback.TracebackCases.test_encoded_file)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_traceback.py", line 439, in test_encoded_file
    do_test("", "foo", "ascii", 3)
    ~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/cpython/cpython/Lib/test/test_traceback.py", line 428, in do_test
    self.assertIn(("line %s" % lineno), stdout[1],
                                        ~~~~~~^^^
IndexError: list index out of range

----------------------------------------------------------------------
@hugovk
Copy link
Member

hugovk commented Apr 25, 2024

See also #117672 (comment) and #112730 (comment).

@nineteendo
Copy link
Contributor Author

Do we disable these tests like #118247?

@hugovk
Copy link
Member

hugovk commented Apr 25, 2024

Maybe, let's see if someone can fix the root cause first. The JIT is experimental and the CI is allowed to fail, it's mainly an annoyance when it does.

@mdboom mdboom added the performance Performance or resource usage label Apr 25, 2024
@mdboom
Copy link
Contributor

mdboom commented Apr 25, 2024

Cc: @brandtbucher

@brandtbucher
Copy link
Member

Maybe, let's see if someone can fix the root cause first. The JIT is experimental and the CI is allowed to fail, it's mainly an annoyance when it does.

Agreed. Since it's affecting others (not just the JIT emulation) it is probably worth actually fixing or handling more generally.

@brandtbucher
Copy link
Member

Perhaps the tests could just patch the desired environment variables instead of wiping them out completely?

@savannahostrowski
Copy link
Contributor

I think that this is now fixed as I don't see the failures anymore on CI runs. I think that #118288 fixed things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance or resource usage
Projects
None yet
Development

No branches or pull requests

5 participants