Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Tier 2 interpreter out of _PyEval_EvalFrameDefault #116970

Open
gvanrossum opened this issue Mar 18, 2024 · 2 comments
Open

Move Tier 2 interpreter out of _PyEval_EvalFrameDefault #116970

gvanrossum opened this issue Mar 18, 2024 · 2 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@gvanrossum
Copy link
Member

gvanrossum commented Mar 18, 2024

See discussion starting here: faster-cpython/ideas#631 (comment)

Basically, we see no real perf improvement for having the two switches inside the same function, and we have some indication that on Windows the compiler is failing to optimize this giant function. In addition, the logic for each of the interpreters is somewhat complicated due to sharing variables and labels.

This is not as simple as reverting gh-111428 (issue gh-111520), but in the abstract, that's the proposal.

The priority isn't clear, but it's probably doing before the 3.13 feature freeze.

@gvanrossum
Copy link
Member Author

This will probably be superseded by issue gh-118335 and its PR (gh-118339).

@gvanrossum
Copy link
Member Author

This will probably be superseded by issue gh-118335 and its PR (gh-118339).

(Not really, when configured the Tier 2 interpreter will still co-habitate with the Tier 1 interpreter. But it's unclear if it matters, and we may dust it off later.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Development

No branches or pull requests

1 participant