Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GitHub action to automatically update projects #467

Open
6 of 8 tasks
ezio-melotti opened this issue Jul 1, 2022 · 5 comments
Open
6 of 8 tasks

Add a GitHub action to automatically update projects #467

ezio-melotti opened this issue Jul 1, 2022 · 5 comments
Assignees

Comments

@ezio-melotti
Copy link
Member

ezio-melotti commented Jul 1, 2022

This is a meta issue about a newly added GitHub action that automatically updates projects:


python/cpython#94447 added a first version of the workflow that updates the Release and Deferred blockers project, and:

  • I tested that the issue is added to the project when:
    • the release-blocker label is applied
    • the deferred-blocker label is applied
  • removing the label doesn't remove the issue from the project
  • there doesn't seem to be a way to set the type automatically from the action
    • it can be set manually either in the issue or in the project
  • it takes about 10-15s before the issue (dis)appears in the project
  • a manual refresh on the issue is needed before the project (dis)appears in the sidebar

After attempting backports in python/cpython#94477 and python/cpython#94475, the check failed because it couldn't access the secret. After some investigation it turns out that PRs created from forks can't access secrets. In addition, this action would add a check for each job in the PR (currently only one, but I'm planning to add more for the other labels/projects):

Click to see screenshot of the job in the PR checks list

image

Therefore, I submitted python/cpython#94483 to remove the pull_request trigger and only run the action for issues, solving the issue with the secret and the extra checks in PRs.

@ezio-melotti
Copy link
Member Author

@auscompgeek
Copy link

pull_request trigger

Would using the pull_request_target trigger work instead?

@ezio-melotti
Copy link
Member Author

Even if it does, I'm not sure we want to add PRs to the projects anymore.

@python python deleted a comment from HACKED-need-HELP Oct 29, 2022
@ezio-melotti
Copy link
Member Author

Projects now support a workflow to automatically add issues/PRs to projects, even though it seems to have some limitations (e.g. can't set custom fields based on a label, and also limitations based on the account type).
For now I enabled it as a test to the Release and deferred blockers project -- if it works well we could enable it on more projects and get rid of the workflow added in python/cpython#94447.

See:

@CAM-Gerlach
Copy link
Member

Also, Triagers can now add issues/PRs to projects directly due to the changes in #460 , as far as I'm aware, so anyone who can add a label can also add directly to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Status: Todo
Development

No branches or pull requests

3 participants