Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full # noqa support #185

Open
2 of 7 tasks
jakkdl opened this issue Apr 30, 2023 · 0 comments
Open
2 of 7 tasks

full # noqa support #185

jakkdl opened this issue Apr 30, 2023 · 0 comments

Comments

@jakkdl
Copy link
Member

jakkdl commented Apr 30, 2023

Making a separate issue from #181 to track all current issues/TOODs with # noqa

  • 0 Respect noqa-trio as a way to have full flake8-noqa support
  • 1 Don't autofix noqa'd errors
    • This might not be a huge issue atm, but is a must going forward as more visitors get autofix support.
  • 2 Raise error if invalid (or not enabled) TRIO error code is noqa'd.
    • Not a must, and sort of covered by flake8-noqa. But if it's a simple logic addition there's not much reason not to.
  • 3 raise noqad errors when running as a plugin noqa now correctly ignored when running as plugin. ast-based visitors… #188
    • otherwise we're fully incompatible with flake8-noqa
  • 4 support --disable-noqa
  • 5 document current level of [in]compatibility with flake8-noqa
  • 6 respect # noqa in ast visitors. noqa now correctly ignored when running as plugin. ast-based visitors… #188
  • 7 check that # noqa comments are resilient to line numbers changing due to autofix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant