Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated imp module with importlib #789

Open
hugovk opened this issue Apr 29, 2023 · 1 comment
Open

Replace deprecated imp module with importlib #789

hugovk opened this issue Apr 29, 2023 · 1 comment

Comments

@hugovk
Copy link

hugovk commented Apr 29, 2023

Expected behaviour

Works with Python 3.12.

Actual behaviour

This project uses the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

What are the steps to reproduce this issue?

Input clear steps to reproduce the issue for a maintainer.

  1. git grep "\bimp\b"

fp, pathname, description = imp.find_module("shopify")
self._shopify_api = imp.load_module("shopify", fp, pathname, description)

@nijel
Copy link
Member

nijel commented Apr 30, 2023

Actually, I don't see a reason for not using import directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants