Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to ignore parsing of commit body #733

Open
erschmidt opened this issue Oct 10, 2023 · 3 comments · May be fixed by #866
Open

Add option to ignore parsing of commit body #733

erschmidt opened this issue Oct 10, 2023 · 3 comments · May be fixed by #866
Assignees
@codejedi365
Labels
confirmed Prevent from becoming stale feature A new feature or a feature request

Comments

@erschmidt
Copy link

Description

Add an option to ignore the body of a commit message during commit parsing. Ideally in commit_parser_options.

Use cases

From v7 to v8, the changelog seems to use all the information from the commit message. This introduces issues when using squash and merge and keeping the default commit messages (actually breaks the changelog for some reason; e.g., pre-commit is complaining about mixed line endings). Since the commit body - at least for me - does not contain any relevant information (for the changelog), I would rather not use it at all.

Possible implementation

Add a use_body flag in commit_parser_options
@erschmidt erschmidt added the feature A new feature or a feature request label Oct 10, 2023
@codejedi365
Copy link
Contributor

Working on a solution to fix the breaking of the changelog with squashed commits, with the intent to actually parse the squashed commits.

I'm glad I read this to possibly add the setting to ignore the commit body.

Also, just curious which parser are you using?

@erschmidt
Copy link
Author

Hey, glad to hear that! Currently had to revert back and would love to someday go back to the current version. I am using the default Angular parser.

@codejedi365
Copy link
Contributor

I appreciate it, I'll let you know when it gets merged and published

@github-actions github-actions bot added the stale label Mar 25, 2024
@codejedi365 codejedi365 added confirmed Prevent from becoming stale and removed stale labels Mar 27, 2024
@codejedi365 codejedi365 self-assigned this Mar 27, 2024
@codejedi365 codejedi365 linked a pull request Mar 27, 2024 that will close this issue
feat: improve changelog defaults #866
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codejedi365 codejedi365

Labels
confirmed Prevent from becoming stale feature A new feature or a feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve changelog defaults codejedi365/python-semantic-release
2 participants
@codejedi365 @erschmidt