Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectionPool polite close() call? #120

Open
smferguson opened this issue Apr 27, 2016 · 2 comments
Open

ConnectionPool polite close() call? #120

smferguson opened this issue Apr 27, 2016 · 2 comments

Comments

@smferguson
Copy link

Hey guys,
We're beginning use of happybase and will be rolling it into prod in the coming weeks.
I'm curious why the connectionpool doesn't have a polite close() call.
I have code locally that loops over the pool and tries to close the connections, but I feel like there may be context (history) I'm missing.
Thanks,
Scott

@wbolster
Copy link
Member

No, there isn't any history or other context. A simple loop should do the trick indeed, perhaps it makes sense to have it in Happybase itself.

@smferguson
Copy link
Author

Cool. I'll submit a PR. Thanks for the quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants