Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!reddit command doesn’t filter nsfw subreddits. #1153

Closed
scrazzz opened this issue Sep 12, 2020 · 6 comments · Fixed by #1157
Closed

!reddit command doesn’t filter nsfw subreddits. #1153

scrazzz opened this issue Sep 12, 2020 · 6 comments · Fixed by #1157
Assignees
@RohanJnr
Labels
a: information Related to information commands: (doc, help, information, reddit, site, tags) p: 1 - high High Priority t: feature New feature or request

Comments

@scrazzz
Copy link

scrazzz commented Sep 12, 2020 •
edited

So yeah, as the title says !reddit command doesn’t filter nsfw subreddits ._.

doing: !reddit top nsfw displays the direct URL link to the nsfw subreddit.
@RohanJnr
Copy link
Member

RohanJnr commented Sep 12, 2020 •
edited

this should be a simple fix as done here
https://github.com/python-discord/seasonalbot/blob/master/bot/exts/evergreen/reddit.py#L57
it's another Reddit command, but for seasonalbot

We just check if over_18 is true or false, which will be in the response we get after sending the Http request.

the fix could be implemented at this line

bot/bot/cogs/reddit.py

Line 143 in 7ebc481

posts = content["data"]["children"]

@scrazzz
Copy link
Author

scrazzz commented Sep 12, 2020

Nice. Hopefully they implement this 👍

@scrazzz scrazzz closed this as completed Sep 12, 2020
@jb3
Copy link
Member

jb3 commented Sep 12, 2020

We should keep this open until it is implemented.

@jb3 jb3 reopened this Sep 12, 2020
@RohanJnr
Copy link
Member

I would like to finish this

@ikuyarihS
Copy link
Member

@RohanJnr I've assigned the issue to you

@RohanJnr
Copy link
Member

thanks

@RohanJnr RohanJnr mentioned this issue Sep 15, 2020
Merged
@MarkKoz MarkKoz added a: information Related to information commands: (doc, help, information, reddit, site, tags) p: 1 - high High Priority t: feature New feature or request labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RohanJnr RohanJnr

Labels
a: information Related to information commands: (doc, help, information, reddit, site, tags) p: 1 - high High Priority t: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reddit: restrict nsfw subreddit(s) RohanJnr/bot
5 participants
@MarkKoz @ikuyarihS @jb3 @RohanJnr @scrazzz