New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attrs deviation from PEP 681 #1170
Comments
probably related: microsoft/pyright#6572 |
Hey @hynek, What are your thoughts around this issue? |
I don’t think those two issues are related. The Pyright issue is that dataclasses implement the MRO wrong which becomes obvious with multiple inheritance. To be fair, it might’ve copied it from early attrs versions that did it wrong too. Changing that would be a very hard backwards-compatibility breakage in addition to plainly wrong. It's the default in My understanding of the I think there even was an issue asking for a dataclass compat API so I guess we could reimplement some their bugs within our I’m sorry by not being responsive here, but I get angry whenever I re-read the pontification of how we implement a PEP wrong which has been written long after attrs was implemented and that was the only way for us to get any Pylance/Pyright support whatsoever. We had no choice in this matter and did our best to cooperate and them pointing fingers at us now for not breaking our users doesn't feel great. |
According to the Pylance developers attrs deviates from PEP 681 in the way it treats
kw_only
in field overridemicrosoft/pylance-release#4670
The text was updated successfully, but these errors were encountered: