-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Thumbnails not downloaded, curl error 404, when scraping subscriptions from a file #669
Comments
You could try using |
Could it be that this was a misunderstanding of the supported thumbnail types in invidious? There is no I've tried every instance I can find and none of them return anything for https://<instance_url>/vi/AKZRuNZDkGU/high.jpg but they all return an image for https://<instance_url>/vi/AKZRuNZDkGU/hqdefault.jpg This makes me think the default quality should be Also I can reproduce this very consistently with |
tbh, edit: |
I think it's because You are converting
PS. I have no idea how you stay organized in a 3565 line long file.... And also sorry if I'm way off here. EDIT: I tried adding |
Its hard lol.
I think you're right. I will add this patch when I get home. I believe adding the function call is the best solution, but it might be better if it gets called automatically somewhere. |
This should now be fixed in the development branch. |
Thanks! Just tested and it's working great now. |
Describe the bug
When running
ytfzf -t -f -c SI
thumbnails are not downloaded and some curl 404 errors go to stderr:To Reproduce
run ytfzf -t -f -c SI with the following subscriptions file:
Expected behavior
Thumbnails similar to those displayed when using the
invidious-channel
featureScreenshots
Information
alacritty
ytfzf: 2.5.5
(from aurytfzf-git r1963.ac4cc79-1
)ls -l "$(which sh)"
(if you're using fish:ls -l (which sh)
):lrwxrwxrwx 1 root root 4 Jan 8 2022 /usr/sbin/sh -> bash*
ytfzf --thumbnail-log=log.txt
and post the file: The file is emptyAdditional context
I did some testing using
bash -x
to get debug output. Here's download log output from a working invidious-channel scrape:and here's one from a not working
-cSI
scrape against my subscriptions file:I tried downloading the image from both.
https://invidious.baczek.me/vi/1qtg1z5V1ss/hqdefault.jpg
contains an image whilehttps://invidious.baczek.me/vi/1qtg1z5V1ss/high.jpg
does not. Though I cant figure out why the two types of scrapes request different quality images. I think this may not be related though since neither URL is a 404. I hope this is helpful though.This is the only place thumbnails are broken for me. They work with all other searches and scrapes.
Thanks!
The text was updated successfully, but these errors were encountered: