You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In simulator/base.py, dateutil.parser is used in the .load method for loading saved simulation results. That module is imported at the top level, but not listed in our requirements in setup.py. Under a "minimal" pysb install, importing pysb.simulator therefore fails. Our CI setups install pandas, which has python-dateutil as a dependency, so we never noticed the issue (this brings up a separate issue of how to fix CI to catch this in the future).
Since pysb generates this timestamp with isoformat(), we can parse it with datetime.fromisoformat() instead of the very general-purpose dateutil.parser.parse.
The text was updated successfully, but these errors were encountered:
In
simulator/base.py
, dateutil.parser is used in the.load
method for loading saved simulation results. That module is imported at the top level, but not listed in our requirements in setup.py. Under a "minimal" pysb install, importingpysb.simulator
therefore fails. Our CI setups install pandas, which has python-dateutil as a dependency, so we never noticed the issue (this brings up a separate issue of how to fix CI to catch this in the future).Since pysb generates this timestamp with
isoformat()
, we can parse it withdatetime.fromisoformat()
instead of the very general-purposedateutil.parser.parse
.The text was updated successfully, but these errors were encountered: