Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: remove deprecated kp tag: '' #101

Open
aburrell opened this issue Nov 17, 2022 · 7 comments
Open

MAINT: remove deprecated kp tag: '' #101

aburrell opened this issue Nov 17, 2022 · 7 comments
Milestone

Comments

@aburrell
Copy link
Member

Description

GFZ changed their database, and the old format of files are not available any longer. The new dataset is of higher quality, and so we will remove support for the old dataset in version 0.2.0+ of pysatSpaceWeather.

@aburrell aburrell added this to the 1.0.0 milestone Nov 17, 2022
@aburrell aburrell changed the title MAINT: removed deprecated kp tag: '' MAINT: remove deprecated kp tag: '' Nov 17, 2022
@hococoder
Copy link

Are there plans for a near term fix to support the extra resolution provided by this format update?

@aburrell
Copy link
Member Author

aburrell commented Nov 22, 2022

The fixes are in on the 'develop' branch. @hococoder, can you confirm that these are the extent of the changes needed? If that fixes all the current problems I can get a bugfix release out.

@hococoder
Copy link

@aburrell yay! I copied over the new code in the affected part of the file, and it seems to work (It is at least definitely not crashing anymore). So it looks like it did parse correctly. Thanks for the quick turnaround - please let me know when an official bug fix release is out.

@hococoder
Copy link

@aburrell just a heads up - instead of just updating the affected code, i upgraded to 0.0.8 and now am having major issues downloading kp data. Is this a known potential issue? I will try to get a issue filed once I get to a stopping point with what I am working on

@aburrell
Copy link
Member Author

aburrell commented Dec 9, 2022 via email

@hococoder
Copy link

I didn't see any warnings, and this wasn't for historic, but recent data. I'll file an issue when I can since this sounds like something unique

@JonathonMSmith
Copy link
Contributor

I can also say that the '' deprecation warning does not appear to be working in the develop branch.

import datetime as dt
import pysat
import pysatSpaceWeather
date = dt.datetime(2020, 1, 1)
kp = pysat.Instrument(inst_module=pysatSpaceWeather.instruments.sw_kp)
kp.download(date)
kp.load(date=date)

Only returns the warning about MetaHeader

@aburrell aburrell modified the milestones: 1.0.0, 0.2.0 Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants