Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Consider alternative binning method that may scale better #22

Open
rstoneback opened this issue Apr 16, 2021 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@rstoneback
Copy link
Collaborator

rstoneback commented Apr 16, 2021

Is your feature request related to a problem? Please describe.
Binning algorithms of order (N) scales better to large bin sets. Current algorithm is worse than that.

Describe the solution you'd like
For sorted arrays we can use a variant of this solution, which has already be tweaked as part of this pull.

np.digitize now works on multidimensional arrays, that's good. This can then be parsed using np.unique save having to do a bunch of np.where's, which is also good. We may have to sort multiple times... less than good. Unique doesn't work how I'd like over multidimensional arrays which prevents the best solution.

Describe alternatives you've considered
Leaving support as is.

Additional context
Add any other context or screenshots about the feature request here.

@rstoneback
Copy link
Collaborator Author

Also see #5, which requests ND binning support, which this technique may generalize better in this area than the current implementation.

@jklenzing jklenzing added the enhancement New feature or request label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants