Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Store orbital elements as a dict #87

Open
jklenzing opened this issue May 18, 2022 · 0 comments
Open

ENH: Store orbital elements as a dict #87

jklenzing opened this issue May 18, 2022 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@jklenzing
Copy link
Member

Is your feature request related to a problem? Please describe.
missions_sgp4 has a lot of kwargs, some of which are mutually exclusive.

Describe the solution you'd like
We could expand the element checks in the orbital methods to store these as a single dict for input, similar to how pysat treats "orbit_info". Could reduce duplication if new instruments are added down the line.

Describe alternatives you've considered
Rely on the docstrings in the instrument to sort it our.

Additional context
thoughts from codeclimate review (too many kwargs in load)

@jklenzing jklenzing added the enhancement New feature or request label May 18, 2022
@jklenzing jklenzing added this to the 0.4.0 Release milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant