Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: expanded data range #69

Open
jklenzing opened this issue Sep 7, 2021 · 3 comments
Open

ENH: expanded data range #69

jklenzing opened this issue Sep 7, 2021 · 3 comments
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@jklenzing
Copy link
Member

Is your feature request related to a problem? Please describe.
The current data range of available orbits is three years based on inheritance from pysat.

Describe the solution you'd like
Tie to the start and stop dates to 1957 to 2056, the operational range of TLEs.

Describe alternatives you've considered
The runtime does increase when carrying around a longer list of files. As a test, changing from a three-year range to a hundred-year range increases the run time about 40% (from 0.47s to 0.64s per orbit on average, running >100 orbits randomly). In theory we could also pass through file_date_range as an optional argument for a quicker version of this, but may still run into an overhead issue.

Additional context
The list of fake files is required by pysat, ie, a file must exist before it can be loaded.

See #66 for more discussion.

@jklenzing jklenzing added the enhancement New feature or request label Sep 7, 2021
@jklenzing
Copy link
Member Author

Currently the code mirrors the pysat test instruments in that it creates a date range of three years around the nominal test date. I can hardwire a file_date_range into the instrument, but this prevents me from passing through the alternate file_date_range as a kwarg when initializing the instrument.

@jklenzing jklenzing added the question Further information is requested label Dec 23, 2021
@jklenzing
Copy link
Member Author

Adding a question label since this may be dropped. Adding a custom file_date_range has been sufficient in current analysis, but needs may change down the line.

@jklenzing jklenzing added this to the 0.4.0 Release milestone Sep 2, 2022
@jklenzing
Copy link
Member Author

Should make a design decision by 0.4.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant