Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP: missions_ephem instrument #71

Merged
merged 6 commits into from Jan 26, 2022
Merged

DEP: missions_ephem instrument #71

merged 6 commits into from Jan 26, 2022

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Dec 23, 2021 •
edited

Description

Closes #57

Adds deprecation warning and tests to mission_ephem. The pyephem package is no longer being updated, and the sgp4 + geospacepy seems like it does the same job in the end.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Instantiate a missions_ephem instrument with warnings turned on.

Test Configuration:

  • Operating system: Mac OS 11.6.1
  • Version number python 3.8.11

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no unexpected warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

@jklenzing jklenzing added this to the 0.3.0 release milestone Dec 23, 2021
@jklenzing jklenzing marked this pull request as ready for review December 23, 2021 17:04
@jklenzing jklenzing linked an issue Dec 23, 2021 that may be closed by this pull request
MAINT: pyephem no longer updated #57
Open
JonathonMSmith
JonathonMSmith reviewed Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@JonathonMSmith JonathonMSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the changelog need a line in testing for deprecation warning testing? Or is that best left alone or put in with the deprecation line?

jklenzing
jklenzing commented Jan 14, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@jklenzing jklenzing merged commit b293568 into develop Jan 26, 2022
@jklenzing jklenzing deleted the dep/ephem branch January 26, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathonMSmith JonathonMSmith JonathonMSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0 release
Development

Successfully merging this pull request may close these issues.

MAINT: pyephem no longer updated
2 participants
@jklenzing @JonathonMSmith