Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: generalize download methods #30

Merged
merged 17 commits into from Oct 28, 2021
Merged

ENH: generalize download methods #30

merged 17 commits into from Oct 28, 2021

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Oct 21, 2021

Description

Addresses #3 (partial)

  • Moves the download method to pysatCDAAC.instruments.methods.general for reuse in other instruments
  • Downloads tar files to a temporary directory
  • Uses test date for postProc files to test out backup code as part of integration tests
  • Generalizes input to support multiple future data products
  • Cleans up style and implements flake8 checks

Note: v0.0.2 was released, updated changelog accordingly.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Via pytest.

Test Configuration:

  • Operating system: Mac OS X 10.15.7
  • Version number: Python 3.8.11

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@jklenzing jklenzing changed the title Enh/generalize ENH: generalize download methods Oct 21, 2021
setup.py Outdated Show resolved Hide resolved
pysatCDAAC/instruments/methods/general.py Outdated Show resolved Hide resolved
@jklenzing
Copy link
Member Author

ROADMAP comment: this should be sufficient to add in COSMIC2 IVM data.

@jklenzing jklenzing marked this pull request as ready for review October 26, 2021 18:28
@jklenzing jklenzing added the enhancement New feature or request label Oct 26, 2021
@jklenzing jklenzing linked an issue Oct 26, 2021 that may be closed by this pull request
3 tasks
@jklenzing jklenzing mentioned this pull request Oct 27, 2021
11 tasks
Copy link
Collaborator

@rstoneback rstoneback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jklenzing!

@jklenzing jklenzing merged commit 081cc90 into develop Oct 28, 2021
@jklenzing jklenzing deleted the enh/generalize branch October 28, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: move reusable methods from cosmic_gps to methods
2 participants