Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: test for clean_warn breaks if not every inst_id / tag combo has a warning message for cleaning #1196

Open
jklenzing opened this issue Apr 9, 2024 · 0 comments
Labels

Comments

@jklenzing
Copy link
Member

Description

The current setup for test_clean_warn assumes that if the _clean_warn property is present, it is present for every tag.

if hasattr(inst_dict['inst_module'], '_clean_warn'):
clean_warn = inst_dict['inst_module']._clean_warn[
inst_dict['inst_id']][inst_dict['tag']]

For some instruments (e.g., dmsp_sussi, timed_guvi) this is not true, and tests will fail when run.

To Reproduce this bug:

run pysatNASA tests with pysat 3.2.0

Options

  • Use try / except notation in this test. If there is a KeyError present, tags do not exist for this combo and use pytest skip
  • Use keys for all tag / inst_id combos, potentially with some other trigger to skip the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant