Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for instruments where they load a time without data #1128

Open
aburrell opened this issue Jun 23, 2023 · 1 comment
Open

Add a test for instruments where they load a time without data #1128

aburrell opened this issue Jun 23, 2023 · 1 comment
Assignees
Labels
Milestone

Comments

@aburrell
Copy link
Member

aburrell commented Jun 23, 2023

Is your feature request related to a problem? Please describe.
After adding a new instrument with a custom load function, I learned that the test suite does not try to load times where no data has been downloaded as a part of the standard test suite. This is important to ensure the load return values when no data is present are correct.

Describe the solution you'd like
Test to ensure that load for times without data returns an empty meta object and an empty pandas DataFrame or xarray Dataset.

Describe alternatives you've considered
Ignoring this gap

Additional context
Lines missing coverage in new Madrigal instrument. from this pull request: pysat/pysatMadrigal#89

@jklenzing jklenzing added this to the 3.2.0 Release milestone Jul 5, 2023
@jklenzing
Copy link
Member

jklenzing commented Jul 5, 2023

Implementation idea: add a load test with a date prior to the test date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants