Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: values being popped and reset when writing files #1122

Open
jklenzing opened this issue May 9, 2023 · 0 comments
Open

STY: values being popped and reset when writing files #1122

jklenzing opened this issue May 9, 2023 · 0 comments
Labels
style An issue or question about the best way of doing things. For example, does this follow PEP-8?
Milestone

Comments

@jklenzing
Copy link
Member

Is your feature request related to a problem? Please describe.
A number of parameters are popped in to_netcdf and rewritten by pysat. These include
'Date_End', 'Date_Start', 'File', 'File_Date', 'Generation_Date', 'Logical_File_ID'

Describe the solution you'd like
This may be unnecessary since the variables are rewritten. Preliminary tests suggest so.

Describe alternatives you've considered
Could be necessary in some cases. Maintain belt and braces to ensure these params are always accurate.

Additional context
Discovered in the context of #1117

@jklenzing jklenzing added this to the 3.2.0 Release milestone May 31, 2023
@jklenzing jklenzing added the style An issue or question about the best way of doing things. For example, does this follow PEP-8? label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style An issue or question about the best way of doing things. For example, does this follow PEP-8?
Projects
None yet
Development

No branches or pull requests

1 participant