Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove geom_col argument in element_as_gdf()? #722

Open
jGaboardi opened this issue May 8, 2023 · 2 comments
Open

remove geom_col argument in element_as_gdf()? #722

jGaboardi opened this issue May 8, 2023 · 2 comments
Assignees

Comments

@jGaboardi
Copy link
Member

jGaboardi commented May 8, 2023

#720 introduced a small ruff regression where the geom_col keyword is no longer used in util._arcs_as_gdf(), which triggers a ruff failure in pre-commit.

The thought here is that maybe we should remove the geom_col argument in element_as_gdf()? And always default to "geometry".


EDIT

@martinfleis
Copy link
Member

Can you think of a use case when you want the column to be called differently and it couldn't be done via an intermediate rename_geometry call?

@jGaboardi
Copy link
Member Author

Nope, I can't think of anything. Let's nix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants