Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkmode Change tab text color #2143

Closed
Melleh98 opened this issue Mar 7, 2024 · 7 comments
Closed

Darkmode Change tab text color #2143

Melleh98 opened this issue Mar 7, 2024 · 7 comments
Labels
needs-more-info Issue required to follow the bug report template. Triggered by the stale issue workflow New Feature New feature request [class->Implemented #{number}: {title}] Stale

Comments

@Melleh98
Copy link

Melleh98 commented Mar 7, 2024

R24 Darkmode tab text color

I just updated my toolbars to show white icons when using R24 dark mode. It works great.
image
image
I also color coördinate my tabs so its easier to look for things.
In darkmode tho the text is almost unreadable.

Ideal solutuion

The best solution for me would be to add a way to edit the text color of the tabs

Alternative solution

An alternatve could be:
Being able to set a different tab color for Darkmode just like we can use PNG's just for the dark mode Icon

@Melleh98 Melleh98 added the New Feature New feature request [class->Implemented #{number}: {title}] label Mar 7, 2024
@jmcouffin
Copy link
Contributor

@dosymep
Could you take a look at that?

@dosymep
Copy link
Member

dosymep commented Mar 11, 2024

@Melleh98, maybe you can choose colour wich same for two modes?

background:
  title: '#31363F'

@jmcouffin, maybe add dark properties?

# set background dark for all parts
background-dark: '#ff0000' 

# or for individual dark parts
background-dark:
  panel: '#ff0000'
  title: '#00ff00'
  slideout: '#0000ff'

@jmcouffin
Copy link
Contributor

@jmcouffin, maybe add dark properties?

That would make sense @dosymep
Would you mind taking care of that?

@github-actions github-actions bot added the needs-more-info Issue required to follow the bug report template. Triggered by the stale issue workflow label Mar 11, 2024
@jmcouffin
Copy link
Contributor

@Melleh98
following Dosymep suggestion you can set color to a middle ground color that works in both cases

https://www.notion.so/pyrevitlabs/pyRevit-Bundles-12323e3090904d9aa7cdc3d82095d3e3?pvs=4#225b2cf0dad24b0395de1930f1070ad6

# set background for all parts
background: '#ff0000'                   # or ARGB e.g. #ff0000ff

# or for individual parts
background:
  panel: '#ff0000'
  title: '#00ff00'
  slideout: '#0000ff'

@jmcouffin jmcouffin removed the needs-more-info Issue required to follow the bug report template. Triggered by the stale issue workflow label Mar 11, 2024
@jmcouffin
Copy link
Contributor

@dosymep or maybe just have a text-color-dark attribute to just change the text color?

@github-actions github-actions bot added the needs-more-info Issue required to follow the bug report template. Triggered by the stale issue workflow label Mar 11, 2024
Copy link
Contributor

"👋 Hi there! It looks like there hasn't been any activity on this issue for the past 60 days. We understand that things can get busy.
Just a friendly reminder that this issue is scheduled to be automatically closed in 14 days if there's no further activity.
If you still need assistance or have additional information to share, please feel free to comment, and we'll be happy to help! 🚀
Thanks for your understanding!"

@github-actions github-actions bot added the Stale label May 11, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-info Issue required to follow the bug report template. Triggered by the stale issue workflow New Feature New feature request [class->Implemented #{number}: {title}] Stale
Projects
None yet
Development

No branches or pull requests

3 participants